Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix Ledger Tests to be Feature-Gated

This PR fixes the CI failure in PR #31 by properly feature-gating the Ledger wallet tests. The issue was that the CI workflow runs tests with --no-default-features, but the Ledger implementation requires the ledger feature to be enabled.

Changes

  • Added #[cfg(feature = "ledger")] to the Ledger tests module
  • Wrapped the test in a module to ensure proper feature-gating
  • No changes to the actual implementation

This ensures that the tests are only compiled and run when the ledger feature is enabled, preventing compilation errors when running with --no-default-features.

Link to Devin run: https://app.devin.ai/sessions/bc2a0d70f17f44518478567e1d0f8730
Requested by: Jimmy

devin-ai-integration bot and others added 2 commits February 27, 2025 04:58
Co-Authored-By: Jimmy <jinghui@wayne.edu>
Co-Authored-By: Jimmy <jinghui@wayne.edu>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@Jim8y Jim8y merged commit 53383c3 into master Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant