Skip to content

Feature/core restructure phase5 e2e #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 14, 2025
Merged

Feature/core restructure phase5 e2e #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fcc3792
feat: Phase 1 - Migrate embedders and extractors from framework
r3d91ll Sep 13, 2025
ce6c7ae
test: Add comprehensive unit tests for Phase 1 embedders and extractors
r3d91ll Sep 13, 2025
ce72d9f
fix: Address CodeRabbit review comments for Phase 1
r3d91ll Sep 13, 2025
9a912ec
feat: Phase 2 - Database and Workflows consolidation
r3d91ll Sep 13, 2025
ce0c677
chore: Add CodeRabbit configuration for branch reviews
r3d91ll Sep 13, 2025
18059b6
fix: Correct CodeRabbit YAML configuration syntax
r3d91ll Sep 13, 2025
d1a399d
feat: Comprehensive CodeRabbit config with proper Conveyance Framework
r3d91ll Sep 13, 2025
ec87bd0
fix: Correct CodeRabbit config schema and Conveyance formula
r3d91ll Sep 13, 2025
dec9e52
fix: Address CodeRabbit review comments for Phase 2
r3d91ll Sep 13, 2025
f3b40a9
Merge pull request #38 from r3d91ll/feature/core-restructure-phase2
r3d91ll Sep 13, 2025
6560e63
feat: Phase 3 - Configuration and Monitoring consolidation
r3d91ll Sep 13, 2025
6f4be72
fix: Correct CodeRabbit YAML parsing error
r3d91ll Sep 13, 2025
8ab5680
fix: Address CodeRabbit review comments
r3d91ll Sep 13, 2025
01c775e
Merge pull request #39 from r3d91ll/feature/core-restructure-phase3
r3d91ll Sep 13, 2025
7832e39
feat: Phase 4 - Integration and Import Updates (Issue #35)
r3d91ll Sep 13, 2025
1310761
fix: Address CodeRabbit review comments on PR #40
r3d91ll Sep 13, 2025
a943e72
chore: Directory cleanup - Archive legacy code to Acheron
r3d91ll Sep 13, 2025
7256aaa
Merge pull request #40 from r3d91ll/feature/core-restructure-phase4
r3d91ll Sep 13, 2025
b366f3a
Refactor: Remove legacy ArangoDB scripts and implement new end-to-end…
r3d91ll Sep 14, 2025
26cf890
Add monitoring and workflows modules for pipeline orchestration and p…
r3d91ll Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
# CodeRabbit Configuration (HADES — Conveyance-aligned)
# Enables CodeRabbit to review PRs on all branches, not just main

# Review triggers
reviews:
auto_review:
enabled: true
# Review PRs targeting any branch (not just default)
base_branches:
- "^main$"
- "^feature/.*$"
- "^develop$"
- "^release/.*$"
- "^hotfix/.*$"
Comment on lines +9 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Confirm branch regexes cover your flow.

If you use bugfix/, chore/, or docs/ branches, add them.

🏁 Script executed:

#!/bin/bash
# Verify which remote branches are NOT matched by the configured patterns.
patterns=('^main$' '^feature/.*$' '^develop$' '^release/.*$' '^hotfix/.*$')
git ls-remote --heads origin | awk '{print $2}' | sed 's#refs/heads/##' | python - "$@" << 'PY'
import re,sys
pats=[re.compile(p) for p in sys.argv[1:]]
unmatched=[]
for line in sys.stdin:
  b=line.strip()
  if not any(p.match(b) for p in pats):
    unmatched.append(b)
if unmatched:
  print("Unmatched branches:")
  print("\n".join(sorted(set(unmatched))))
else:
  print("All remote branches match configured patterns.")
PY "${patterns[@]}"

Length of output: 193

🏁 Script executed:

#!/bin/bash
set -euo pipefail
patterns=('^main$' '^feature/.*$' '^develop$' '^release/.*$' '^hotfix/.*$')
git ls-remote --heads origin 2>/dev/null | awk '{print $2}' | sed 's#refs/heads/##' > /tmp/branches.txt || true
if [ ! -s /tmp/branches.txt ]; then
  echo "git ls-remote returned no branches (maybe origin not set or network disabled)."
  exit 0
fi
unmatched=()
while IFS= read -r b; do
  matched=0
  for p in "${patterns[@]}"; do
    if [[ "$b" =~ $p ]]; then matched=1; break; fi
  done
  if [ $matched -eq 0 ]; then unmatched+=("$b"); fi
done < /tmp/branches.txt
if [ ${#unmatched[@]} -gt 0 ]; then
  echo "Unmatched branches:"
  printf "%s\n" "${unmatched[@]}" | sort -u
else
  echo "All remote branches match configured patterns."
fi

Length of output: 281

Add missing branch patterns to .coderabbit.yaml

git ls-remote returned these remote branches that do not match the configured base_branches (file: .coderabbit.yaml, lines 9–14):

  • coderabbitai/docstrings/429692f
  • coderabbitai/docstrings/67e8628
  • coderabbitai/docstrings/7fc37dd
  • coderabbitai/docstrings/91d9a2f
  • coderabbitai/docstrings/ce6c7ae
  • experiement/word2vec_TPB
  • experiement_word2vec_lineage
  • pr-17
  • rebuild_safe
  • separate_pdf_proc_from_arxiv

Update or broaden base_branches to cover them. Suggested additions:

  • ^coderabbitai/docstrings/.*$
  • ^experiement.*$
  • ^pr-.*$
  • ^rebuild_safe$
  • ^separate_pdf_proc_from_arxiv$
    (also add ^bugfix/.$, ^chore/.$, ^docs/.*$ if those flows are used)


# Skip drafts (false => do review drafts)
drafts: false

# Review settings
request_changes_workflow: false
high_level_summary: true
poem: false
review_status: true
collapse_walkthrough: false

# Tools and checks
tools:
ruff:
enabled: true
markdownlint:
enabled: true
languagetool:
enabled: false
shellcheck:
enabled: true
yamllint:
enabled: true

# Path filters - review all files by default, with exclusions
path_filters:
- "**/*" # Review all files
- "!**/node_modules/**"
- "!**/__pycache__/**"
- "!**/.pytest_cache/**"
- "!**/.ruff_cache/**"
- "!**/.mypy_cache/**"
- "!**/venv/**"
- "!**/.venv/**"
- "!**/dist/**"
- "!**/build/**"
- "!**/*.pyc"
- "!**/*.pyo"
- "!**/*.egg-info/**"
- "!**/Acheron/**" # Our deprecated code archive

# Path-specific instructions - apply to all paths
path_instructions:
- path: "**/*"
instructions: |
# HADES — Conveyance Framework (Efficiency view default)

## CRITICAL: Correct Formula
C = (W · R · H / T) · Ctx^α

NOT "WHERE × WHAT × CONVEYANCE × TIME" (this is WRONG)

- W = What (signal/content quality)
- R = Where (relational/topological positioning)
- H = Who (agent/capability leverage)
- T = Time to converge (DIVIDES, not multiplies!)
- Ctx = wL·L + wI·I + wA·A + wG·G (weights default 0.25)
- α ∈ [1.5, 2.0], default 1.7, applies ONLY to Ctx

## Red flags to request changes:
- TIME multiplied rather than divided (look for "× TIME")
- "CONVEYANCE" used as an input factor (C is the outcome, not input)
- Missing WHO (H) in the efficiency equation
- α applied to anything other than Ctx
- Evidence of double-counting time

## Review Focus Areas

1. **Todd's 3 Laws**:
- Data is sacrosanct: validate inputs, no silent data loss
- Reliability: controlled failure modes
- Ownership: comprehensive logging

2. **Factory patterns & interfaces** (H, R)
3. **Backward compatibility** (R, T)
4. **Performance evidence** (T, W)
5. **Observability** (H, T)
6. **Security** (W, R)

## Conveyance Scorecard Output
- Time stance: Efficiency (default) or Capability (if T fixed)
- W/R/H/T summary
- L/I/A/G scores (each in [0,1])
- α value (default 1.7)
- Zero-propagation check
- Evidence links

# Pre-merge checks for PR descriptions
pre_merge_checks:
custom_checks:
- name: "PR description sections"
mode: "warning"
instructions: |
Verify PR description contains:
- Conveyance Summary
- W/R/H/T Mapping
- Performance Evidence
- Tests & Compatibility

# Chat settings
chat:
auto_reply: true
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,3 +388,4 @@ arxiv_pipeline_v2_results_*.json
tools/arxiv/REORGANIZATION_NOTICE.md
tools/arxiv/SCRIPT_REORGANIZATION_ANALYSIS.md
tools/arxiv/utils/SCRIPT_ANALYSIS.md
scratch/*
0 core/mcp_server/__init__.py → .zed/settings.json
View file
Open in desktop
File renamed without changes.
138 changes: 0 additions & 138 deletions MIGRATION_README.md
View file
Open in desktop

This file was deleted.

Loading