feat(windows): support resizable frameless windows with native shadow - #1829
Closed
zhuzipu wants to merge 6 commits into
Closed
feat(windows): support resizable frameless windows with native shadow#1829zhuzipu wants to merge 6 commits into
zhuzipu wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(windows): support resizable frameless windows with native shadow
Enable window resizing for frameless windows when shadow=True on Windows.
Previously, setting frameless=True stripped WS_THICKFRAME and the DWM
sizing border was not available, making resizable=True ineffective when
the native shadow was enabled.
The fix follows the approach used by Electron (borderless-window):
which removes the non-client area while keeping the DWM frame intact.
window border from being drawn over the client area.
the non-client border on activation changes.
SM_CXPADDEDBORDER), with diagonal corner handles wider than the sides,
matching standard Windows behavior.
native window shadow from the extended frame.
hit-test result.
resize modal loop when an edge hit-test result is returned.
WebView2 control to leave a thin border at the window edges so
WM_NCHITTEST messages can reach the parent window procedure.
Thanks for TRAE WORK ( AI ) 🎉🎉🎉~