changed subtitle file naming

[Nightreaver]

The current subtitle naming is note widely supported so I changed it to generally more approved way by using ´.´ instead of ´-´

See example for proper subtitle naming for ie plex:

https://support.plex.tv/articles/200471133-adding-local-subtitles-to-your-media/

most pc video players accept either way, so its more QOL change

[r0oth3x49]

It's more specific to plex naming convention for external subs. can you specify any other? 'm using VLC which don't have any problem with names it detects the subs available.

[geffchang]

@r0oth3x49 @Nightreaver is right. '.' is problematic for VLC. VLC detects the available subs, but it does not use the correct subtitle for what you set as default.

Try this. Use a video with multiple subtitles that uses "-" in the filename instead of '.'. In VLC, goto Tools > Preferences > Subtitles/OSD. Check "Enable subtitles" and set "Preferred subtitle language" to "en". When you open the video, there is a chance that English will not be used. Now, rename the subtitles to use "." instead of "-", and the video will use English when you open it for the first time.

This could be could be a VLC-only issue, since Media Player Classic does not have this problem. But again, "." is the standard. See: https://superuser.com/questions/346599/what-is-naming-convention-for-subtitle-files/346609

[Nightreaver]

Its also standard for MediaBrowser/Emby - https://github.com/MediaBrowser/Wiki/wiki/Subtitles

As I said, regular PC software dont have any issue with more "complex" file nameing, the - also work well for MPC/MPC-BE and probably others. But so does . so changing it would add more compatibility.

Obvioulsy VLC is looking for dot as well, according to their sourcecode https://git.videolan.org/?p=vlc.git;a=blob;f=modules/demux/subtitle.c#l2420

[geffchang]

@Nightreaver I think you also need to update the logging. I see the dash in the logs, even if the actual file uses dot.

e.g.

[+] : Downloaded (313 Creating Eye-Catching Text Effects in PowerPoint-en)

[Nightreaver]

But IMHO, thats not a file name anyways. To me it just indicated something was downloaded with that title, in english. It doesnt even tell what it is ie Subtitle?