Preserve order of CSS classes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of CSS classes matters see http://stackoverflow.com/questions/15670631/does-the-order-of-classes-listed-on-an-item-affect-the-css Change the underlying representation from sets to vectors Adopt the convention : :className comes after the keywordized CSS classes. ie. [:div.a.b {:className "c d"}] ;;=> "a b c d" Deduplicate the same classes ie. [:div.a.b.b {:className "c d"}] ;;=> "a b c d"
r0man
force-pushed
the
preserve-class-order
branch
from
c9be961
to
b175737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of CSS classes matters
see http://stackoverflow.com/questions/15670631/does-the-order-of-classes-listed-on-an-item-affect-the-css
Change the underlying representation from sets to vectors
Adopt the convention : :className comes after the keywordized CSS classes.
ie. [:div.a.b {:className "c d"}] ;;=> "a b c d"
Deduplicate the same classes
ie. [:div.a.b.b {:className "c d"}] ;;=> "a b c d"