refactor: remove config and add generic extension type #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Just one query for one last possible improvement. Its minor, but I prefer to not overexpose things. The VersionedDispatch enum only needs to know the type of he RuntimeCall, not the whole Runtime which implements some Config trait to then determine the RuntimeCall.
Far simpler to only pass the runtime call type.
chungquantin
merged commit de41a05
into
chungquantin/refactor-duplicate_chain_extensions
6 checks passed
chungquantin
added a commit
that referenced
this pull request
Aug 13, 2024
chungquantin
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative design of the PR: #163
Configtrait so there is no relationship between theRuntimeand the extension.ApiExtension.This alternative approach removes all the connections with the
Runtime, every configuration will be on the level of theApiExtension