feat(nfts): add nonfungibles runtime implementation #1531
Triggered via pull request
October 18, 2024 10:36
chungquantin
synchronize
#339
Status
Success
Total duration
11s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
2s
Annotations
34 warnings
constants have by default a `'static` lifetime:
pallets/nfts/src/lib.rs#L70
warning: constants have by default a `'static` lifetime
--> pallets/nfts/src/lib.rs:70:24
|
70 | pub const LOG_TARGET: &'static str = "runtime::nfts";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
missing documentation for an associated function:
runtime/common/src/lib.rs#L125
warning: missing documentation for an associated function
--> runtime/common/src/lib.rs:125:3
|
125 | pub fn is_superset(s: &ProxyType, o: &ProxyType) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a function:
runtime/common/src/lib.rs#L52
warning: missing documentation for a function
--> runtime/common/src/lib.rs:52:1
|
52 | pub const fn deposit(items: u32, bytes: u32) -> Balance {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L49
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:49:1
|
49 | pub const MICROUNIT: Balance = UNIT / 1_000_000; // 10_000
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L48
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:48:1
|
48 | pub const MILLIUNIT: Balance = UNIT / 1_000; // 10_000_000
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L46
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:46:1
|
46 | pub const UNIT: Balance = 10_000_000_000; // 10 decimals
| ^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L31
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:31:1
|
31 | pub const DAYS: BlockNumber = HOURS * 24;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L30
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:30:1
|
30 | pub const HOURS: BlockNumber = MINUTES * 60;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L29
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:29:1
|
29 | pub const MINUTES: BlockNumber = 60_000 / (MILLISECS_PER_BLOCK as BlockNumber);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L22
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:22:1
|
22 | pub const SLOT_DURATION: u64 = MILLISECS_PER_BLOCK;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for the crate:
runtime/common/src/lib.rs#L1
warning: missing documentation for the crate
--> runtime/common/src/lib.rs:1:1
|
1 | / #![cfg_attr(not(feature = "std"), no_std)]
2 | | use frame_support::weights::{constants::WEIGHT_REF_TIME_PER_SECOND, Weight};
3 | | // Cumulus types re-export
4 | | // These types are shared between the devnet and testnet runtimes
... |
136 | | }
137 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
|
constants have by default a `'static` lifetime:
pallets/nfts/src/lib.rs#L70
warning: constants have by default a `'static` lifetime
--> pallets/nfts/src/lib.rs:70:24
|
70 | pub const LOG_TARGET: &'static str = "runtime::nfts";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
missing documentation for an associated function:
runtime/common/src/lib.rs#L125
warning: missing documentation for an associated function
--> runtime/common/src/lib.rs:125:3
|
125 | pub fn is_superset(s: &ProxyType, o: &ProxyType) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a struct:
/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs#L263
warning: missing documentation for a struct
--> runtime/common/src/lib.rs:76:2
|
76 | / parameter_types! {
77 | | // One storage item; key size 32, value size 8; .
78 | | pub const ProxyDepositBase: Balance = deposit(1, 40);
79 | | // Additional storage item size of 33 bytes.
... |
85 | | pub const MaxPending: u16 = 32;
86 | | }
| |_____^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
|
missing documentation for a function:
runtime/common/src/lib.rs#L52
warning: missing documentation for a function
--> runtime/common/src/lib.rs:52:1
|
52 | pub const fn deposit(items: u32, bytes: u32) -> Balance {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L49
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:49:1
|
49 | pub const MICROUNIT: Balance = UNIT / 1_000_000; // 10_000
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L48
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:48:1
|
48 | pub const MILLIUNIT: Balance = UNIT / 1_000; // 10_000_000
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L46
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:46:1
|
46 | pub const UNIT: Balance = 10_000_000_000; // 10 decimals
| ^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L31
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:31:1
|
31 | pub const DAYS: BlockNumber = HOURS * 24;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L30
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:30:1
|
30 | pub const HOURS: BlockNumber = MINUTES * 60;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L29
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:29:1
|
29 | pub const MINUTES: BlockNumber = 60_000 / (MILLISECS_PER_BLOCK as BlockNumber);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a constant:
runtime/common/src/lib.rs#L22
warning: missing documentation for a constant
--> runtime/common/src/lib.rs:22:1
|
22 | pub const SLOT_DURATION: u64 = MILLISECS_PER_BLOCK;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for the crate:
runtime/common/src/lib.rs#L1
warning: missing documentation for the crate
--> runtime/common/src/lib.rs:1:1
|
1 | / #![cfg_attr(not(feature = "std"), no_std)]
2 | | use frame_support::weights::{constants::WEIGHT_REF_TIME_PER_SECOND, Weight};
3 | | // Cumulus types re-export
4 | | // These types are shared between the devnet and testnet runtimes
... |
136 | | }
137 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
|