-
Notifications
You must be signed in to change notification settings - Fork 36
fix: Add is-relay field to pop build spec
#693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb4626c to
5b6a9c3
Compare
5b6a9c3 to
40e2e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a --is-relay flag to the pop build spec command to support generating relay chain specifications without requiring parachain-specific fields (para-id and relay).
Key Changes:
- Added
--is-relayargument that conflicts withpara_idandrelayarguments - Modified
BuildSpecstruct to useOption<u32>forpara_idandOption<RelayChain>forrelay - Updated logic to conditionally skip parachain-specific customizations when building relay chain specs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a couple of small changes.
One more thing: can we cover the new --is-relay behavior in the integration tests?
For example, similar to the flow in https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/tests/chain.rs#L112 but using the --is-relay flag.
moliholy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small suggestion there, but feel free to discard it and merge.
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 76.89% 76.89%
=======================================
Files 109 109
Lines 24549 24635 +86
Branches 24549 24635 +86
=======================================
+ Hits 18877 18944 +67
- Misses 3686 3702 +16
- Partials 1986 1989 +3
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Follows:
pop build specto specify the runtime path as argument #687This PR adds a new arg
--is-relaytopop build spec, which may be used to avoid adding thepara-idandrelaykeys to a relay chain spec