-
Notifications
You must be signed in to change notification settings - Fork 37
feat: build spec runtime #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f559377 to
317ce48
Compare
317ce48 to
e63db6e
Compare
d3ae327 to
f5a1cef
Compare
9ccd703 to
64a6892
Compare
tsenovilla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks overall good!
Thanks for addressing the comments we discussed offline, great job! This was a big one
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, the functionality is clean and well tested!
There are a few changes, like the path parameter or TestChildProcess in the contract crate, that seem slightly out of scope for this PR, but overall it’s a nice, clean refactor.
I just left a couple of small nitpicks in the review, but I am happy to approve after that.
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. Approved, good to go!
Closes #654.
Closes #267.
This PR:
--skip-buildflag has been added to avoid that, although it will be built regardless of the flag if the artifacts are not found.