-
Notifications
You must be signed in to change notification settings - Fork 36
refactor: telemetry #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: telemetry #635
Conversation
401ee02 to
dc116f8
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 109 109
Lines 25464 25465 +1
Branches 25464 25465 +1
==========================================
Hits 19903 19903
- Misses 3481 3482 +1
Partials 2080 2080
🚀 New features to boost your workflow:
|
| glob = { version = "0.3.1", default-features = false } | ||
| log = { version = "0.4.20", default-features = false } | ||
| mockito = { version = "1.4.0", default-features = false } | ||
| wiremock = { version = "0.6.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried axum or mockito crate but it was super hard to assert on the payload send to the mockserver. So ended up using wiremock.
| } | ||
| } | ||
|
|
||
| pub fn cleanup_telemetry_env() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we get back the variables removed in new?
std::env::remove_var("DO_NOT_TRACK");
std::env::remove_var("CI");
| } | ||
|
|
||
| /// Create a `pop` command configured for `dir` with given `args`. | ||
| pub fn pop(dir: &Path, args: impl IntoIterator<Item = impl AsRef<OsStr>>) -> StdCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did this refactor in the tests, once you merge all changes you can take it from: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-common/src/lib.rs#L94
Todo: