Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert relay number check #25

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Jun 7, 2024

It seems that we included a regression.

We configured CheckAssociatedRelayNumber = RelayNumberStrictlyIncreases while using the lookahead collator:

This changed combined with the fact that you are using the lookahead collator and async backing, you run into this error message. The lookahead collator is building multiple parachain blocks on the same relay chain block. This leads to this issue, as the relay chain number is not strictly increasing between parachain blocks. Reverting this change will fix it.


I considered introducing a test for this, so we can verify such a regression is not included in future changes. But being the "base-parachain" and the one we are using to maintain the rest of our templates now and generate them in the future, that felt like maybe too much of an opinion to make.

@al3mart al3mart requested a review from Daanvdplas June 7, 2024 14:24
@al3mart
Copy link
Contributor Author

al3mart commented Jun 7, 2024

This unlocks #23

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my bad, thanks for fixing it.

@al3mart al3mart marked this pull request as ready for review June 7, 2024 14:46
@al3mart
Copy link
Contributor Author

al3mart commented Jun 7, 2024

Awesome, thanks for the quick approval

@al3mart al3mart requested a review from peterwht June 7, 2024 15:02
@al3mart al3mart merged commit 69da041 into main Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants