[DRAFT] Fix/support cross-compiling packages depending on RcppParallel & TBB #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR also requires the development version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of
RcppParallelwill support building the bundled TBB for WASM, this PR proposes an approach for linking against the cross-compiled TBB for packages that need to do so.By downloading a version of
RcppParallelbuilt for WASM and setting theTBB_INCandTBB_LIBpaths for the cross-compilation, everything builds and links without issue.At the moment it's just hard-coding a link to the r-universe WASM build for
RcppParallel- let me know if there's a better or more robust alternative!