Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fs for file path manipulations; closes #38 #40

Merged
merged 17 commits into from
Oct 11, 2024
Merged

Use fs for file path manipulations; closes #38 #40

merged 17 commits into from
Oct 11, 2024

Conversation

mpadge
Copy link
Collaborator

@mpadge mpadge commented Oct 8, 2024

No description provided.

@mpadge mpadge marked this pull request as ready for review October 8, 2024 09:21
@mpadge mpadge requested review from polettif and dhersz October 8, 2024 09:21
@mpadge mpadge mentioned this pull request Oct 8, 2024
Closed
@dhersz
Copy link
Collaborator

dhersz commented Oct 8, 2024

Looking great Mark, thanks!

polettif
polettif reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@polettif polettif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Do we need to change file.path and co in the tests as well or should there be no issues with that?

R/assert_inputs.R Outdated Show resolved Hide resolved
R/export_gtfs.R Show resolved Hide resolved
R/import_gtfs.R Show resolved Hide resolved
R/import_gtfs.R Outdated Show resolved Hide resolved
mpadge and others added 2 commits October 8, 2024 20:55
polettif
polettif approved these changes Oct 11, 2024
View reviewed changes
R/assert_inputs.R Outdated Show resolved Hide resolved
R/export_gtfs.R Show resolved Hide resolved
@mpadge mpadge mentioned this pull request Oct 11, 2024
Closed
@polettif polettif merged commit f2620a0 into r-transit:master Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polettif polettif polettif approved these changes

@dhersz dhersz dhersz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpadge @dhersz @polettif