Skip to content

as_qgis_argument.stars_proxy(): also support stars < 0.6-0 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

as_qgis_argument.stars_proxy(): also support stars < 0.6-0 #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions R/compat-stars.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,19 @@ as_qgis_argument_stars <- function(x, spec = qgis_argument_spec(), use_json_inpu
}
}
# we can only check for total band number; they have no names in stars
stars_ok <- utils::packageVersion("stars") >= as.package_version("0.6-0")
nrbands_match <- identical(
dim(x)["band"],
dim(stars::read_stars(file, proxy = TRUE))["band"]
)
) && # stars < 0.6-0 has different implementation of band selection in stars_proxy
(stars_ok || is.null(attr(x, "call_list")) || dim(x)["band"] == 1L)
if (nrbands_match) {
return(file)
} else {
message(glue(
"Rewriting the stars object as a temporary file before passing to QGIS, since ",
"the number of bands differs from those in the source file '{ file }'."
"the number of bands { ifelse(stars_ok, 'differs', 'may differ') } ",
"from those in the source file '{ file }'."
))
return(write_stars_as_tempfile_arg(x))
}
Expand Down