Reduce number of manual git release steps #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Jan 25, 2023
There was a problem hiding this comment.
I'm pretty ambivalent about these changes, as it feels like I'm going to be faced with choices like "shall we do X and Y?" and I might only want to X but I can't do X until or unless I want to do X and Y at the same time. I guess this reflects different work styles.
#Conflicts: # NEWS.md # R/release.R
hadley
commented
Jan 25, 2023
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
hadley
commented
Jan 25, 2023
hadley
commented
Jan 25, 2023
jennybc
reviewed
Mar 5, 2023
Comment on lines
+214
to
+215
| #' If you use [devtools::submit_cran()] to submit to CRAN, information about the | ||
| #' submitted state is captured in a `CRAN-SUBMISSION` file. |
There was a problem hiding this comment.
I removed a mention of devtools::release(), since submit_cran() is ultimately called in that case as well. Also removed the mention of CRAN-RELEASE since it's been long enough now, since we switched to CRAN-SUBMISSION (late 2021).
|
I remain ambivalent on a few bits of this, but am merging so this doesn't just stall out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_release_issue()checks default branch and pulls automatically.use_github_release()automatically pushes, if safe.use_github_release()just creates the release.use_version()gainspushargument.Fixes #1385. Closes #1678.
@jennybc I did not touch
check_current_branch(), instead focussing on reducing the places in our release checklist where we previously needed to do manual pushes or puls