Skip to content

Remove S4 class after test #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove S4 class after test #1566

merged 1 commit into from
Jan 3, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 3, 2024 •
edited
Loading

Finally, a correct version of #1564 that passes all tests. Ugly, but the only reasonable way I found.

@krlmlr krlmlr requested a review from hadley January 3, 2024 05:31
@krlmlr krlmlr mentioned this pull request Jan 3, 2024
Merged
hadley
hadley approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah because that code is run by roxygen2, not directly in the test.

@hadley hadley merged commit 2b7955a into r-lib:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley