Adapt github_document()
format for @includeRmd
#1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to rstudio/rmarkdown#2331
I believe the issue could be from the fact that
github_document()
is unnecessary rendering a HTML self_contained document.html_preview = FALSE
should be set in the case of@includeRmd
usage.We could obviously also make some adaption regarding the default value in rmarkdown side but this is not as straightforward (preview is want when rendered in background inside IDE)
There may be other adjustment needed so I am creating this as a draft for now until this is tested and sorted out.