fix(package2remote): add a "git" RemoteType for handling git packages installed with pak#838
Merged
gaborcsardi merged 2 commits intor-lib:mainfrom Oct 21, 2025
Merged
fix(package2remote): add a "git" RemoteType for handling git packages installed with pak#838gaborcsardi merged 2 commits intor-lib:mainfrom
gaborcsardi merged 2 commits intor-lib:mainfrom
Conversation
… installed with pak Issue with devtools/remotes for RemoteType "git" Fixes r-lib#830
Member
|
Thanks, this looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve the issue #830 : Issue with devtools/remotes for RemoteType "git"
The RemoteType "git" is now handled like an "xgit" remote type. Therefore git packages installed with pak are now recognised and no error message "can't convert package... to remote" is triggered anymore. I don't think that would create any border effect but I don't really know if "git" RemoteType created by pak must be handled as an "xgit" RemoteType in all cases.
Anyway that's solves my case of package dependencies hosted on private gitlab repositories.