New nested_ifelse_linter #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
AshesITR
reviewed
Mar 25, 2022
R/nested_ifelse_linter.R
Outdated
| lint_message = function(expr) { | ||
| matched_call <- xml2::xml_text(xml2::xml_find_first(expr, "expr/SYMBOL_FUNCTION_CALL")) | ||
| lint_message <- sprintf("Don't use nested %s() calls; instead, try", matched_call) | ||
| paste(lint_message, "(1) data.table::fcase; (2) dplyr::case_when; or (3) merging to a lookup table.") |
There was a problem hiding this comment.
(3) may be better "using a lookup table". If the lookup is just ok one column, new[match(Col, old)] in general or unname(new[old]) for charactes is the optimal code in my testing.
Or maybe "merging or matching to a lookup table"?
There was a problem hiding this comment.
good idea. i like "using a lookup table". The merging approach is pretty ugly in general, if it's needed. The simple named_vector[[lookup_keys]] approach is nicer when it's possible.
AshesITR
approved these changes
Mar 25, 2022
|
my hesitation for adding it as a default is that the "good" alternatives might require new dependencies in general. the base-only alternatives can get pretty ugly... I'll leave it out of defaults for now. we can always revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #962