New class_equals_linter #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
|
I've also seen |
|
awesome, great idea! let's mark extensions like this as new issues for now -- once we have all the linters imported for #962, we can do another round of triage to see what's worth implementing in time for 3.0.0 |
AshesITR
reviewed
Mar 25, 2022
R/class_equals_linter.R
Outdated
| #' @export | ||
| class_equals_linter <- function() { | ||
| Linter(function(source_file) { | ||
| if (length(source_file$parsed_content) == 0L) { |
There was a problem hiding this comment.
Should check for xml_parsed_content since it requires XML
AshesITR
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #962