Skip to content

fix lints #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2022
Merged

fix lints #976

merged 4 commits into from
Mar 22, 2022

Conversation

MichaelChirico
Copy link
Collaborator

There are also:

  • A false-positive expect_length_linter() where info= is used
  • A false-positive expect_comparison_linter() where info= is used
  • Dozens and dozens of expect_identical() lints

Happy to switch our default to expect_identical(), but wanted to check in first -- WDYT?

@AshesITR
Copy link
Collaborator

I don't really see the benefit in doing s/expect_identical/expect_equal/ over our testing codebase at the moment.

@MichaelChirico
Copy link
Collaborator Author

follow-up #975 (comment)

After merge, I still see approval here

image

@MichaelChirico MichaelChirico merged commit b91dc57 into master Mar 22, 2022
@MichaelChirico MichaelChirico deleted the fix-lints branch March 22, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @AshesITR