Skip to content

Change linter_level= arg order for readability #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Change linter_level= arg order for readability #2361

merged 2 commits into from
Nov 28, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Nov 28, 2023

Closes #2355

FWIW I did this in VSCode-in-GitHub with the following find-and-replace:

Search pane:

\}, linter_level = "(file|expression)")

Find-and-replace:

Linter\(([\na-zA-Z._;%`()~|&#'"/:*\[\]0-9@+ {}<>!?^$,=-]+\}), (linter_level = "[a-z]+")\)
Linter($2, $1)

Note that .+ doesn't work because it needs to include \n.

Two final usages not matching the above pattern were found in clean-up:

[^(]linter_level =

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cba4fa6) 99.41% compared to head (373a43b) 99.40%.

❗ Current head 373a43b differs from pull request most recent head 69adc34. Consider uploading reports for the commit 69adc34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
- Coverage   99.41%   99.40%   -0.01%     
==========================================
  Files         124      124              
  Lines        5655     5561      -94     
==========================================
- Hits         5622     5528      -94     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR AshesITR merged commit a9659c2 into main Nov 28, 2023
@AshesITR AshesITR deleted the style branch November 28, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange linter_level= in our code.
3 participants