Skip to content

also skip slot extractions akin to dollar #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 6, 2023
Merged

also skip slot extractions akin to dollar #2039

merged 10 commits into from
Aug 6, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Aug 4, 2023

Noticed this during #2038.

Figured it would affect other linters too, so I grep'd through for OP-DOLLAR to determine which others to include.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #2039 (d0dcff7) into main (3e6b862) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head d0dcff7 differs from pull request most recent head c09d105. Consider uploading reports for the commit c09d105 to get more accurate results

@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
- Coverage   98.56%   98.56%   -0.01%     
==========================================
  Files         114      114              
  Lines        5011     5002       -9     
==========================================
- Hits         4939     4930       -9     
  Misses         72       72              
Files Changed Coverage Δ
R/object_name_linter.R 98.18% <ø> (ø)
R/T_and_F_symbol_linter.R 100.00% <100.00%> (ø)
R/condition_message_linter.R 100.00% <100.00%> (ø)
R/for_loop_index_linter.R 100.00% <100.00%> (ø)
R/literal_coercion_linter.R 90.00% <100.00%> (ø)
R/undesirable_function_linter.R 100.00% <100.00%> (ø)
R/unreachable_code_linter.R 100.00% <100.00%> (ø)
R/yoda_test_linter.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit 191e3b7 into main Aug 6, 2023
@MichaelChirico MichaelChirico deleted the obj-name-at branch August 6, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants