Skip to content

Bump needed {withr} version #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 19, 2022
Merged

Bump needed {withr} version #1412

merged 10 commits into from
Jun 19, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

In order to use the lines parameter from withr::local_tempfile().

Closes #1404

@IndrajeetPatil
Bump needed {withr} version
10bb63a 
In order to use the `lines` parameter from `withr::local_tempfile()`.

Closes #1404
AshesITR
AshesITR reviewed Jun 18, 2022
View reviewed changes
AshesITR
AshesITR reviewed Jun 19, 2022
View reviewed changes
AshesITR
AshesITR requested changes Jun 19, 2022
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also refactor the usages at

  • test-parse_exclusions.R:153
  • test-get_source_expressions.R:266
  • test-get_source_expressions.R:282
  • test-get_source_expressions.R:294

@IndrajeetPatil
Copy link
Collaborator Author

Please also refactor the usages at

  • test-parse_exclusions.R:153
  • test-get_source_expressions.R:266
  • test-get_source_expressions.R:282
  • test-get_source_expressions.R:294

Done.

AshesITR
AshesITR approved these changes Jun 19, 2022
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaelChirico MichaelChirico merged commit 89f31e3 into r-lib:main Jun 19, 2022
@MichaelChirico
Copy link
Collaborator

Thanks @IndrajeetPatil !!

@jimhester could you add Indrajeet as a collaborator?

@IndrajeetPatil IndrajeetPatil deleted the 1404_use_latest_withr branch June 21, 2022 17:08
@IndrajeetPatil
Copy link
Collaborator Author

Thanks, @MichaelChirico and @jimhester! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump withr dependency to 2.5.0 and use local_tempfile(lines = ) in tests
3 participants
@IndrajeetPatil @MichaelChirico @AshesITR