Auto-detect imported objects from packages in object_usage_linter()
#1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO it's a tidyverse bug that its dependencies aren't so declared, but maybe we're missing something... added a comment to the existing bug requesting clarification: |
|
LGTM here. I'm surprised this wasn't done previously 😳 |
MichaelChirico
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1127.
The example provided in the original issue is more complex because
library(tidyverse)doesn't export the functions used.Instead, it attaches other packages as a side-effect. I don't have a good idea how to (without acutally running
library(...)) detect these.IIRC, the packages aren't even registered as
Depends.