-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cpp11_should_unwind_protect
altogether
#327
Merged
DavisVaughan
merged 7 commits into
r-lib:main
from
DavisVaughan:fix/faulty-unwind-protect-variable
Jul 28, 2023
Merged
Remove cpp11_should_unwind_protect
altogether
#327
DavisVaughan
merged 7 commits into
r-lib:main
from
DavisVaughan:fix/faulty-unwind-protect-variable
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
fix/faulty-unwind-protect-variable
branch
from
July 27, 2023 19:25
5525adc
to
98343fe
Compare
DavisVaughan
force-pushed
the
fix/faulty-unwind-protect-variable
branch
from
July 27, 2023 19:27
98343fe
to
7fd15aa
Compare
kevinushey
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lionel-
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice writeup!
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #325
Closes #326
unwind_protect()
call (since the destructors won't run if a longjmp occurs)unwind_protect()
manually to avoid the performance hitNote that this makes the example from #298 very slow again, because nested
unwind_protect()
is no longer "optimized". This is an example where character vector manipulation may be better with a manualunwind_protect()
+ R C API usage