Skip to content

Don't rely on global constructors for the preserved list #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2021
Merged

Don't rely on global constructors for the preserved list #223

merged 3 commits into from
Aug 16, 2021

Conversation

bkietz
Copy link
Collaborator

@bkietz bkietz commented Aug 11, 2021 •
edited
Loading

fixes #224

@bkietz bkietz requested a review from jimhester August 11, 2021 14:02
@bkietz bkietz marked this pull request as ready for review August 11, 2021 14:31
@bkietz
Copy link
Collaborator Author

bkietz commented Aug 11, 2021

See also: apache/arrow#10908

@nealrichardson nealrichardson mentioned this pull request Aug 11, 2021
Closed
jimhester
jimhester reviewed Aug 16, 2021
View reviewed changes
@bkietz bkietz merged commit daaac76 into r-lib:master Aug 16, 2021
@bkietz bkietz deleted the dont-rely-on-preserved-constructor branch August 16, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimhester jimhester jimhester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpp11::preserved relies on ordered global construction
2 participants
@bkietz @jimhester