Skip to content

Change internal cpp11::stop() to C++ exceptions #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 13, 2021

Conversation

sbearrows
Copy link
Contributor

Fixes #203

First attempt so let me know if this looks correct.

@jimhester
Copy link
Member

These should throw some sort of classed exception object, e.g. one of https://en.cppreference.com/w/cpp/error/exception or a custom cpp11 exception class that derives from std::exception.

Possibly https://en.cppreference.com/w/cpp/error/invalid_argument would work for most of them, but you should use your judgement as to what is most appropriate for each case.

@sbearrows
Copy link
Contributor Author

Okay thank you!

Copy link
Member

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, you can merge this whenever you are done and the tests pass.

@sbearrows sbearrows merged commit d8ebaec into r-lib:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change instances of cpp11::stop() to C++ style exceptions
2 participants