Skip to content

Conversation

jimhester
Copy link
Member

The previous behavior was resulting in a compiler crash which was
causing travis to hang.

This fixes the issue on my local vagrant VM, hopefully will also fix it when run on travis.

r-lib/covr#165 is opened to track this issue, I will have a fix in covr devel soon.

The previous behavior was resulting in a compiler crash which was
causing travis to hang
@jeroen jeroen merged commit b5b0cac into r-lib:master Apr 19, 2016
@jeroen
Copy link
Member

jeroen commented Apr 19, 2016

Thanks! Is there something I can suggest to upstream cmark to fix this or is this mostly a bug in covr?

@jimhester
Copy link
Member Author

I think it is just a bug in covr (the intent was to override -02 which wasn't happening) plus a possible bug in commonmark or gcc. It is possible this is due to a bug in commonmark but I am not sure it is worth tracking down.

@jeroen
Copy link
Member

jeroen commented Apr 19, 2016

OK well thanks for fixing. Is there a small reproducible example with cmark that we can give the cmark author, or does the problem seem to be related to R?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants