Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifying multiple processors in provenance column #303

Closed
juliepierson opened this issue Dec 13, 2022 · 8 comments
Closed

specifying multiple processors in provenance column #303

juliepierson opened this issue Dec 13, 2022 · 8 comments

Comments

@juliepierson
Copy link

Hi, I'm trying to add a process with 2 processors in the provenance column. I could not validate my metadata with one process and 2 processors with geoflow, so I tried by duplicating the process and adding 2 processors, so that process and processor count match (hope I'm clear here !). geoflow ran ok, but in the metadata that was created in geonetwork, one process did not have any creator.

If it's possible to do this, maybe the best way to solve this would be to allow multiple processors for one process ? If for example 4 processors participated in one process, the current way would be to create 4 identical processes, which is a bit repetitive in the final metadata. But I understand this would mean a change in the way it's working now, to keep the correspondance between process and processors.

If its' not currently possible to change this, there still may be a bug since a process with no processor gets created by specifying 2 process and 2 processors with my data.

Thanks for your help !

@eblondel
Copy link
Collaborator

@juliepierson thanks for reporting
This one may need some brainstorming how we should better implement the process/lineage through tabular metadata. Indeed there is a limitation for now that forces users to specify 1 processor for each process. It's a constraint

What i can think immediatly is:

  • see if we could append index numbers to processor key to indicate which process
  • avoid eventually setting processors in this column, but to list them instead in the contact "Creator" column,

Processors (in "Provenance", or "Creator" columns) would look like this:

processor1:me_
processor1:him_
processor2:me_
processor2:her_
processor3:theothers

which would match the following processes (not sure if we need to put indexes here as well - maybe):

process:process1_
process:process2_
process:process3

I cc to @juldebar i know he had given some feedback in the past, because struggling with the same syntax as you.

@juliepierson
Copy link
Author

Thanks @eblondel, that looks like a good way to solve this problem !

@eblondel eblondel self-assigned this Jan 2, 2023
@eblondel eblondel added this to the 1.0.0 milestone Jan 2, 2023
eblondel added a commit that referenced this issue Jan 2, 2023
@eblondel
Copy link
Collaborator

eblondel commented Jan 2, 2023

@juliepierson i've implemented it

@eblondel
Copy link
Collaborator

eblondel commented Jan 2, 2023

@juldebar @wheintz @mrouan please see above changes for processes definition to overcome the limitation of defining one processor by process. Processors should be now defined as part of the contact column.

@eblondel
Copy link
Collaborator

eblondel commented Jan 2, 2023

BTW, in the context of #298 this will include an additional refactoring for processes definition. In principle, we will need to define number of process (as for processors).

@juliepierson
Copy link
Author

Thanks @eblondel , will test it soon !

@juliepierson
Copy link
Author

Works ok for me, specifying processors in "Creator" column 😄

@eblondel
Copy link
Collaborator

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants