Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update branch #83

Merged
merged 33 commits into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e977d05
add favicon
benubah Sep 16, 2022
b520b6d
add pdf epub options
SaranjeetKaur Sep 16, 2022
e1067ae
add local copy of image in the Introduction
hturner Sep 26, 2022
e619af8
update GitHub action to deploy PDF and EPUB
hturner Sep 26, 2022
f934789
remove bs4 book
hturner Sep 26, 2022
af4aa2a
add instruction on previewing PDF/EPUB
hturner Sep 26, 2022
4595ce6
Update README.md
SaranjeetKaur Sep 26, 2022
6cabeca
Merge pull request #70 from r-devel/pdf-download
SaranjeetKaur Sep 26, 2022
a7a0365
try adding namespace to output formats
hturner Sep 26, 2022
ee6dac3
Merge pull request #69 from r-devel/add-favicon
SaranjeetKaur Sep 26, 2022
e668450
Update 07-documenting_R.Rmd
bettinagruen Sep 30, 2022
136cd7f
docs: update README.md [skip ci]
allcontributors[bot] Oct 12, 2022
80041b9
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 12, 2022
64dc719
Merge pull request #75 from r-devel/all-contributors/add-MichaelChirico
SaranjeetKaur Oct 12, 2022
3a05c74
docs: update README.md [skip ci]
allcontributors[bot] Oct 12, 2022
1d529a3
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 12, 2022
7bc785d
Merge pull request #76 from r-devel/all-contributors/add-bettinagruen
SaranjeetKaur Oct 12, 2022
c282189
docs: update README.md [skip ci]
allcontributors[bot] Oct 12, 2022
49227a0
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 12, 2022
6f8e9a1
Merge pull request #77 from r-devel/all-contributors/add-nbenn
SaranjeetKaur Oct 12, 2022
4a7b383
docs: update README.md [skip ci]
allcontributors[bot] Oct 12, 2022
0274ec2
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 12, 2022
340831a
Merge pull request #78 from r-devel/all-contributors/add-benubah
SaranjeetKaur Oct 12, 2022
838262b
docs: update README.md [skip ci]
allcontributors[bot] Oct 12, 2022
cdf39ad
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 12, 2022
1a312a8
Merge pull request #79 from r-devel/all-contributors/add-tdhock
SaranjeetKaur Oct 12, 2022
268b578
change to bug-reporting channel
SaranjeetKaur Oct 14, 2022
2dee8cf
docs: update README.md [skip ci]
allcontributors[bot] Oct 14, 2022
cd57ce9
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 14, 2022
aa0f362
Merge pull request #80 from r-devel/all-contributors/add-llrs
SaranjeetKaur Oct 14, 2022
2b499a7
docs: update README.md [skip ci]
allcontributors[bot] Oct 14, 2022
2d5e913
docs: update .all-contributorsrc [skip ci]
allcontributors[bot] Oct 14, 2022
ba9b9d7
Merge pull request #81 from r-devel/all-contributors/add-SaranjeetKaur
SaranjeetKaur Oct 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 45 additions & 6 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@
"question",
"eventOrganizing",
"talk",
"video"
"video",
"review",
"example",
"research"
]
},
{
Expand All @@ -63,7 +66,12 @@
"avatar_url": "https://avatars.githubusercontent.com/u/6818218?v=4",
"profile": "http://llrs.dev",
"contributions": [
"review"
"review",
"content",
"question",
"research",
"doc",
"example"
]
},
{
Expand All @@ -73,7 +81,9 @@
"profile": "http://tdhock.github.io",
"contributions": [
"review",
"example"
"example",
"research",
"question"
]
},
{
Expand All @@ -82,7 +92,9 @@
"avatar_url": "https://avatars.githubusercontent.com/u/3341603?v=4",
"profile": "https://github.com/bettinagruen",
"contributions": [
"review"
"review",
"research",
"question"
]
},
{
Expand Down Expand Up @@ -119,7 +131,10 @@
"profile": "https://github.com/MichaelChirico",
"contributions": [
"review",
"question"
"question",
"content",
"doc",
"research"
]
},
{
Expand Down Expand Up @@ -178,12 +193,36 @@
"contributions": [
"review"
]
},
{
"login": "nbenn",
"name": "nbenn",
"avatar_url": "https://avatars.githubusercontent.com/u/3158446?v=4",
"profile": "https://github.com/nbenn",
"contributions": [
"review",
"research",
"question"
]
},
{
"login": "benubah",
"name": "Ben",
"avatar_url": "https://avatars.githubusercontent.com/u/11357251?v=4",
"profile": "https://github.com/benubah",
"contributions": [
"content",
"review",
"research",
"question"
]
}
],
"contributorsPerLine": 7,
"projectName": "rdevguide",
"projectOwner": "r-devel",
"repoType": "github",
"repoHost": "https://github.com",
"skipCi": true
"skipCi": true,
"commitConvention": "angular"
}
17 changes: 11 additions & 6 deletions .github/workflows/deploy_bookdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ jobs:
name: Render-Book
runs-on: macOS-latest
steps:
- uses: actions/checkout@v1
- uses: r-lib/actions/setup-r@v1
- uses: r-lib/actions/setup-pandoc@v1
- uses: actions/checkout@v3
- uses: r-lib/actions/setup-r@v2
- uses: r-lib/actions/setup-pandoc@v2
- uses: r-lib/actions/setup-tinytex@v2
- name: Install rmarkdown
run: Rscript -e 'install.packages(c("rmarkdown","bookdown"))'
- name: Render Book
run: Rscript -e 'bookdown::render_book("index.Rmd")'
- uses: actions/upload-artifact@v1
- name: Render HTML
run: Rscript -e 'bookdown::render_book("index.Rmd", "bookdown::gitbook")'
- name: Render PDF
run: Rscript -e 'bookdown::render_book("index.Rmd", "bookdown::pdf_book")'
- name: Render ePub
run: Rscript -e 'bookdown::render_book("index.Rmd", "bookdown::epub_book")'
- uses: actions/upload-artifact@v3
with:
name: docs
path: docs/
Expand Down
2 changes: 1 addition & 1 deletion 01-Introduction.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This guide is heavily influenced by the [Python Developer Guide](https://devguid

This guide is built using bookdown which makes editing it easier, provided you have a GitHub account (sign-up at [github.com](https://github.com/)). After you log-in to GitHub, click on the ‘Edit’ icon highlighted with a red ellipse in the image below. This will take you to an editable version of the the source R Markdown file that generated the page you are on:

![](https://user-images.githubusercontent.com/28556616/122679827-03314a80-d20a-11eb-9714-06ae588127f0.png)
![Screenshot of the toolbar in the HTML version of the guide, with the Edit button (pencil and paper icon) circled in red.](img/edit_icon.png)

Use the [issue tracker](https://github.com/forwards/rdevguide/issues) to raise an issue about the guide’s content or to make a feature request.

Expand Down
2 changes: 1 addition & 1 deletion 04-reviewing_bugs_in_R.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ If you would like to see how bugs are reviewed on Bugzilla, [here](https://bugs.

**Note**:

There is a `#bugreports-for-review` channel on the [R Contributors slack](https://r-contributors.slack.com/) where you can share your bug report(s) for review/feedback before submitting to Bugzilla. This can help with checking that it really is a bug, that you have included the important information and excluded redundant information.
There is a `#bug-reporting` channel on the [R Contributors slack](https://r-contributors.slack.com/) where you can share your bug report(s) for review/feedback before submitting to Bugzilla. This can help with checking that it really is a bug, that you have included the important information and excluded redundant information.

## See also

Expand Down
2 changes: 1 addition & 1 deletion 07-documenting_R.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ The language used in the documentations should follow these basic rules:

3. Short code examples can help in understanding better. Readers can often grasp a simple example more quickly than they can digest a formal description. Usually people learn faster with concrete, motivating examples that match the context of a typical use case.

4. Giving a code equivalent (or approximate equivalent) can be a useful in addition to the description provided. You should carefully weigh whether the code equivalent adds value to the document.
4. Giving a code equivalent (or approximate equivalent) can be a useful addition to the description provided. You should carefully weigh whether the code equivalent adds value to the document.

5. The tone of the documentation needs to be respectful of the reader’s background. Lay out the relevant information, show motivating use cases, provide glossary links, and do your best to connect-the-dots. The documentation is meant for newcomers, many of whom will be using it to evaluate the R language as a whole. The experience needs to be positive and not leave the reader with worries that something bad will happen if they make a mistake.

Expand Down
Loading