Add cherry-pickable shim for hsm signing #1330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REOPENING AGAIN
Our build infrastructure uses a private-key that doesn't meet the latest minimum cryptography standards for code signing. This PR offers a patch which can be cherry-picked atop
v2.1.1...v2.2.4
to build older versions using a newer HSM method (currently tailored for AWS KMS).To keep this PR as simple as possible, it will always be force-pushed so that all changes exist in a single cherry-pickable commit.
To apply to an older tagged release:
signing.tsaurl
inprivate.properties
hsm.xxx
signing property values above per Sign with AWS KMS ebourg/jsign#157Disadvantage: