removed the lower limit of pool size

[TechAlchemistry]

No description provided.

[TechAlchemistry]

Hi! Why do not you merge this PR?

[TechAlchemistry]

... ?

[qxsch]

Sorry for my late response, but a workerpool schould have at least one worker. So removing the whole if, introduces a potential bug.
We could consider, changing the value from 2 to 1.

[TechAlchemistry]

@qxsch But the setWorkerPoolSize method already has a lower limit check.

       public function setWorkerPoolSize($size) {
		if ($this->created) {
			throw new WorkerPoolException('Cannot set the Worker Pool Size for a created pool.');
		}
		$size = (int)$size;
		if ($size <= 0) {
			throw new \InvalidArgumentException('"' . $size . '" is not an integer greater than 0.');
		}
		$this->workerPoolSize = $size;
		return $this;
	}

[TechAlchemistry]

Thank you!

[qxsch]

You're welcome! Sorry again for my late response and thank you for your contribution.

[TechAlchemistry]

You are welcome ;) 16 сен 2017 г. 15:38 пользователь "qxsch" <notifications@github.com> написал:

…

You're welcome! Sorry again for my late response and thank you for your contribution. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEP9nRfwjhyxFcGR_ASW_CZ-IkaGm02nks5si8FJgaJpZM4NE4gd> .