Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 348 remote env drishya #351

Merged
merged 27 commits into from
Mar 18, 2024
Merged

Issue 348 remote env drishya #351

merged 27 commits into from
Mar 18, 2024

Conversation

drishyatm
Copy link
Collaborator

We have implemented the remote_credentials.py as env.remote

Changed files :

.circleci/config.yml
conf/browser_os_name_conf.py
conf/remote_credentials.py
page_objects/Base_Page.py
page_objects/driverfactory.py
page_objects/drivers/remote_options.py
utils/BrowserStack_Library.py
utils/interactive_mode.py

Added file

env_remote as replacement for remote_credentials_conf

Deleted file
conf/remote_credentials.py

How to test :

Switch to branch
Rename the file env_remote as ".env.remote"
Provide the BS or SL details into it
Execute /Run the pytest
you could see the browserstack link with the test running on it.

Readme.md Outdated
|__conf: For all configurations and credential files
|__conf: For all configurations

|__env For credential files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we creating new directory "env" and keeping .env file there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Do you say , no need to mention about the ".env" in structure ? env is not as folder , I was mentioning it as file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here your representation shows at env. Please remove it from structure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already did! Latest change will not show env in structure

Readme.md Outdated
@@ -138,6 +140,16 @@ a) Directory structure of our current Templates
COMMANDS FOR RUNNING TESTS
---------------------------

Templates for.env files are accessible.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to move this session under Prerequisites or create new session after prerequisites. You may title it as "Configure environmental variables"

import conf.base_url_conf
import conf.screenshot_conf
from utils import Gif_Maker
from utils import accessibility_util
from utils import snapshot_util

load_dotenv('.env.remote')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this at multiple places?

@@ -17,7 +17,7 @@ jobs:

- run: git clone https://github.com/qxf2/bitcoin-info.git

- run: openssl aes-256-cbc -d -md sha256 -in ./conf/remote_credentials_enc.py -out ./conf/remote_credentials.py -pass env:KEY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete remote_credentials_enc.py file also.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Fixed all feedbacks !

@drishyatm drishyatm linked an issue Mar 6, 2024 that may be closed by this pull request
@drishyatm drishyatm merged commit 6d70199 into master Mar 18, 2024
2 checks passed
shivahari pushed a commit that referenced this pull request Mar 22, 2024
* move the conf to the .env file
* added to ignore the .env
* updated the readme file

---------

Co-authored-by: Qxf2 <mak@qxf2.com>
@rohandudam rohandudam deleted the issue_348_remote_env_drishya branch November 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read common config variables from .env file in our framework
3 participants