-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 348 remote env drishya #351
Conversation
… into issue_348_remote_env_drishya
Readme.md
Outdated
|__conf: For all configurations and credential files | ||
|__conf: For all configurations | ||
|
||
|__env For credential files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we creating new directory "env" and keeping .env file there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Do you say , no need to mention about the ".env" in structure ? env is not as folder , I was mentioning it as file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here your representation shows at env. Please remove it from structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already did! Latest change will not show env in structure
Readme.md
Outdated
@@ -138,6 +140,16 @@ a) Directory structure of our current Templates | |||
COMMANDS FOR RUNNING TESTS | |||
--------------------------- | |||
|
|||
Templates for.env files are accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to move this session under Prerequisites or create new session after prerequisites. You may title it as "Configure environmental variables"
page_objects/Base_Page.py
Outdated
import conf.base_url_conf | ||
import conf.screenshot_conf | ||
from utils import Gif_Maker | ||
from utils import accessibility_util | ||
from utils import snapshot_util | ||
|
||
load_dotenv('.env.remote') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this at multiple places?
… into issue_348_remote_env_drishya
…2/qxf2-page-object-model into issue_348_remote_env_drishya
@@ -17,7 +17,7 @@ jobs: | |||
|
|||
- run: git clone https://github.com/qxf2/bitcoin-info.git | |||
|
|||
- run: openssl aes-256-cbc -d -md sha256 -in ./conf/remote_credentials_enc.py -out ./conf/remote_credentials.py -pass env:KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete remote_credentials_enc.py file also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Fixed all feedbacks !
… into issue_348_remote_env_drishya
* move the conf to the .env file * added to ignore the .env * updated the readme file --------- Co-authored-by: Qxf2 <mak@qxf2.com>
We have implemented the remote_credentials.py as env.remote
Changed files :
.circleci/config.yml
conf/browser_os_name_conf.py
conf/remote_credentials.py
page_objects/Base_Page.py
page_objects/driverfactory.py
page_objects/drivers/remote_options.py
utils/BrowserStack_Library.py
utils/interactive_mode.py
Added file
env_remote as replacement for remote_credentials_conf
Deleted file
conf/remote_credentials.py
How to test :
Switch to branch
Rename the file env_remote as ".env.remote"
Provide the BS or SL details into it
Execute /Run the pytest
you could see the browserstack link with the test running on it.