-
Notifications
You must be signed in to change notification settings - Fork 148
feat(styled kit): tailwind v4 update #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9aeb6e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
8958788 to
73be2e8
Compare
73be2e8 to
5d61f34
Compare
|
We will submit this to potential alpha testers before merging as this is a pretty big change. |
c99e906 to
fdec682
Compare
|
Is it just me or did the Accordion slide animation stop working when moving to tw4? |
|
@jim-pettersson-github It works on this PR. I've been busy with Qwik bundling issues though... |
What is it?
Why is it needed?
Closes #1115.
npx @tailwindcss/upgrade!importantattribute on hidden elements prevented the component from calculating the offsetHeight of the CollapsibleContent (see v4 preflight adds !important on [hidden] attribute, unexpectedly preventing override tailwindlabs/tailwindcss#18653 (comment) and Add details abouthiddenattribute preflight rules tailwindlabs/tailwindcss.com#2321)Upgrade guide:
npx @tailwindcss/upgradescript and let it do most of the work for you@source “../../../path/to/your/components“;Checklist:
pnpm changeand documented my changes