Skip to content

Commit

Permalink
Revert of (Tiny) Temporarily enable hang report capture. (patchset Pi…
Browse files Browse the repository at this point in the history
…ssandshittium#4 id:80001 of https://chromiumcodereview.appspot.com/1891563002/ )

Reason for revert:
Single day experiment is complete.

Original issue's description:
> Temporarily enable hang report capture.
>
> Overview:
> Browser process hangs are believed to be responsible for a large
> fraction of browser unclean shutdowns on Windows. This patch enables
> hang report capture to get visibility into the problem.
>
> Note:
> - Capture only occurs on canary Chrome for users with stats consent.
> - The plan is to release for a single day.
>
> BUG=478209
>
> Committed: https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722
> Cr-Commit-Position: refs/heads/master@{#387473}

TBR=jochen@chromium.org,pmonette@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209

Review URL: https://codereview.chromium.org/1892843002

Cr-Commit-Position: refs/heads/master@{#387589}
  • Loading branch information
manzagop authored and Commit bot committed Apr 15, 2016
1 parent 2fcc0be commit fc8ea0d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions build/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1070,9 +1070,9 @@
# Windows.
['OS=="win" and target_arch=="ia32" and branding=="Chrome"', {
# Enable hang reports from the watcher process.
'kasko_hang_reports%': 1,
'kasko_hang_reports%': 0,
# Enable failed rendez-vous reports.
'kasko_failed_rdv_reports%': 1,
'kasko_failed_rdv_reports%': 0,
}, {
# Enable hang reports from the watcher process.
'kasko_hang_reports%': 0,
Expand Down
6 changes: 2 additions & 4 deletions third_party/kasko/kasko.gni
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//build/config/chrome_build.gni")
import("//build/config/sanitizers/sanitizers.gni")

declare_args() {
# Enable the reporting of browser hangs with Kasko.
# TODO(pmonette): ensure hang reporting is disabled for syzyasan builds.
enable_kasko_hang_reports = is_win && is_chrome_branded && target_cpu == "x86"
enable_kasko_hang_reports = false

# Enable the reporting of failed browser rendez-vous with Kasko.
# TODO(pmonette): ensure hang reporting is disabled for syzyasan builds.
enable_kasko_failed_rdv_reports =
is_win && is_chrome_branded && target_cpu == "x86"
enable_kasko_failed_rdv_reports = false
}

# Enable the Kasko crash reporter. Enabled by default on syzyasan build.
Expand Down

0 comments on commit fc8ea0d

Please sign in to comment.