make CTPolicyEnforcer::CheckCompliance a const method

Bug: 848277 Change-Id: I18d1215ee805756482d1fd740f990cb64fe96268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5091497 Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1236519}
qweri0p · Dec 12, 2023 · f22622d · f22622d
1 parent dac09c7
commit f22622d
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 16 deletions.
diff --git a/components/certificate_transparency/chrome_ct_policy_enforcer.cc b/components/certificate_transparency/chrome_ct_policy_enforcer.cc
@@ -103,7 +103,7 @@ ChromeCTPolicyEnforcer::~ChromeCTPolicyEnforcer() {}
 CTPolicyCompliance ChromeCTPolicyEnforcer::CheckCompliance(
     net::X509Certificate* cert,
     const net::ct::SCTList& verified_scts,
-    const net::NetLogWithSource& net_log) {
+    const net::NetLogWithSource& net_log) const {
   // If the build is not timely, no certificate is considered compliant
   // with CT policy. The reasoning is that, for example, a log might
   // have been pulled and is no longer considered valid; thus, a client

diff --git a/components/certificate_transparency/chrome_ct_policy_enforcer.h b/components/certificate_transparency/chrome_ct_policy_enforcer.h
@@ -65,7 +65,7 @@ class COMPONENT_EXPORT(CERTIFICATE_TRANSPARENCY) ChromeCTPolicyEnforcer
   net::ct::CTPolicyCompliance CheckCompliance(
       net::X509Certificate* cert,
       const net::ct::SCTList& verified_scts,
-      const net::NetLogWithSource& net_log) override;
+      const net::NetLogWithSource& net_log) const override;
 
   // Updates the list of logs used for compliance checks. |disqualified_logs|
   // is a map of log ID to disqualification date.

diff --git a/content/browser/web_package/signed_exchange_handler_unittest.cc b/content/browser/web_package/signed_exchange_handler_unittest.cc
@@ -161,7 +161,7 @@ class GMockCertVerifier : public net::CertVerifier {
 
 class MockCTPolicyEnforcer : public net::CTPolicyEnforcer {
  public:
-  MOCK_METHOD3(
+  MOCK_CONST_METHOD3(
       CheckCompliance,
       net::ct::CTPolicyCompliance(net::X509Certificate* cert,
                                   const net::ct::SCTList& verified_scts,

diff --git a/net/cert/ct_policy_enforcer.cc b/net/cert/ct_policy_enforcer.cc
@@ -11,7 +11,7 @@ namespace net {
 ct::CTPolicyCompliance DefaultCTPolicyEnforcer::CheckCompliance(
     X509Certificate* cert,
     const ct::SCTList& verified_scts,
-    const NetLogWithSource& net_log) {
+    const NetLogWithSource& net_log) const {
   return ct::CTPolicyCompliance::CT_POLICY_BUILD_NOT_TIMELY;
 }
 

diff --git a/net/cert/ct_policy_enforcer.h b/net/cert/ct_policy_enforcer.h
@@ -38,7 +38,7 @@ class NET_EXPORT CTPolicyEnforcer {
   virtual ct::CTPolicyCompliance CheckCompliance(
       X509Certificate* cert,
       const ct::SCTList& verified_scts,
-      const NetLogWithSource& net_log) = 0;
+      const NetLogWithSource& net_log) const = 0;
 };
 
 // A default implementation of Certificate Transparency policies that is
@@ -53,7 +53,7 @@ class NET_EXPORT DefaultCTPolicyEnforcer : public net::CTPolicyEnforcer {
   ct::CTPolicyCompliance CheckCompliance(
       X509Certificate* cert,
       const ct::SCTList& verified_scts,
-      const NetLogWithSource& net_log) override;
+      const NetLogWithSource& net_log) const override;
 };
 
 }  // namespace net

diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -70,10 +70,10 @@ class FailsTestCertVerifier : public CertVerifier {
 // A mock CTPolicyEnforcer that returns a custom verification result.
 class MockCTPolicyEnforcer : public CTPolicyEnforcer {
  public:
-  MOCK_METHOD3(CheckCompliance,
-               ct::CTPolicyCompliance(X509Certificate* cert,
-                                      const ct::SCTList&,
-                                      const NetLogWithSource&));
+  MOCK_CONST_METHOD3(CheckCompliance,
+                     ct::CTPolicyCompliance(X509Certificate* cert,
+                                            const ct::SCTList&,
+                                            const NetLogWithSource&));
 };
 
 class MockRequireCTDelegate : public TransportSecurityState::RequireCTDelegate {

diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
@@ -585,10 +585,10 @@ class DeleteSocketCallback : public TestCompletionCallbackBase {
 // A mock CTPolicyEnforcer that returns a custom verification result.
 class MockCTPolicyEnforcer : public CTPolicyEnforcer {
  public:
-  MOCK_METHOD3(CheckCompliance,
-               ct::CTPolicyCompliance(X509Certificate* cert,
-                                      const ct::SCTList&,
-                                      const NetLogWithSource&));
+  MOCK_CONST_METHOD3(CheckCompliance,
+                     ct::CTPolicyCompliance(X509Certificate* cert,
+                                            const ct::SCTList&,
+                                            const NetLogWithSource&));
 };
 
 class MockRequireCTDelegate : public TransportSecurityState::RequireCTDelegate {

diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc
@@ -115,7 +115,7 @@ class MockCTPolicyEnforcer : public CTPolicyEnforcer {
   ct::CTPolicyCompliance CheckCompliance(
       X509Certificate* cert,
       const ct::SCTList& verified_scts,
-      const NetLogWithSource& net_log) override {
+      const NetLogWithSource& net_log) const override {
     return ct::CTPolicyCompliance::CT_POLICY_COMPLIES_VIA_SCTS;
   }
 };

diff --git a/net/url_request/url_request_quic_unittest.cc b/net/url_request/url_request_quic_unittest.cc
@@ -66,7 +66,7 @@ class MockCTPolicyEnforcerNonCompliant : public CTPolicyEnforcer {
   ct::CTPolicyCompliance CheckCompliance(
       X509Certificate* cert,
       const ct::SCTList& verified_scts,
-      const NetLogWithSource& net_log) override {
+      const NetLogWithSource& net_log) const override {
     return ct::CTPolicyCompliance::CT_POLICY_NOT_DIVERSE_SCTS;
   }
 };