Skip to content

Commit

Permalink
Revert of Roll breakpad 37070c5..eaedc45 (patchset Pissandshittium#2
Browse files Browse the repository at this point in the history
…id:20001 of https://codereview.chromium.org/2719553002/ )

Reason for revert:
Likely causing crbug.com/696257.

Original issue's description:
> Roll breakpad 37070c5..eaedc45
>
> eaedc45 Improve stack sanitization unittests.
> 0ca6751 Handle ntdll only emitting PUBLIC at func entry
> c7e826f Make stack sanitization elide pointers to non-executable mappings.
> 918f3dc Use the correct PC when determining whether to skip storing a stack.
> f9d3ab8 minidump: mark Read as override in derived classes
> 3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
> 3996c1b libdisasm: add upstream/license details
> 603f8b6 There is no need to use the main queue just for perform selector.
> e6123b1 Appveyor CI for Windows MSVS build
> 376784d processor: drop set-but-unused variable
> 122d65d macho_reader_unittest: use EXPECT_FALSE
> 093fab2 windows: fix build on pre-Win10 systems
> 620e0fb windows: update gtest/gmock paths
> fc92bb3 fix write() unused-result warning
> d5f233d Fixed leak of unloaded module lists.
>
> symupload.exe was built by generating a vsproj using gyp, and building a
> Release build in VS 2015.
>
> R=thestig@chromium.org
> BUG=678874
>
> Review-Url: https://codereview.chromium.org/2719553002
> Cr-Commit-Position: refs/heads/master@{#452979}
> Committed: https://chromium.googlesource.com/chromium/src/+/12a3f61803fefb0aeb06f3f4093ea8b06a29fbb3

TBR=thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=678874

Review-Url: https://codereview.chromium.org/2719703004
Cr-Commit-Position: refs/heads/master@{#453115}
  • Loading branch information
sgraham authored and Commit bot committed Feb 26, 2017
1 parent 15d4509 commit f1b19ba
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ allowed_hosts = [

deps = {
'src/breakpad/src':
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + 'eaedc4571ccc7438955c084b8923dcf9e852bd47',
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '37070c5e680f3356f7b14d239518a104edbc2c97',

'src/buildtools':
Var('chromium_git') + '/chromium/buildtools.git' + '@' + Var('buildtools_revision'),
Expand Down
Binary file modified breakpad/symupload.exe
Binary file not shown.

0 comments on commit f1b19ba

Please sign in to comment.