Skip to content

Commit

Permalink
Fix jumbo compilation for Android in //base
Browse files Browse the repository at this point in the history
The define of "Long" to "long" ended up changing some "Long"
strings in jni code to "long" which broke compilation.

Bug: 775547
Change-Id: If9dab9f193b0cad5067903f46ade98155254c7de
Reviewed-on: https://chromium-review.googlesource.com/758366
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#514883}
  • Loading branch information
bratell-at-opera authored and Commit Bot committed Nov 8, 2017
1 parent 6b4d0b1 commit efa1e60
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions base/third_party/dmg_fp/README.chromium
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ List of changes made to original code:
- fixed parsing of long exponents, see exp_length.patch and crbug.com/542881
- made hexdig array const
- removed deprecated `register` keyword
- #undef Long so that it won't change Long in other files in jumbo builds
2 changes: 2 additions & 0 deletions base/third_party/dmg_fp/dtoa_wrapper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ inline static void FREE_DTOA_LOCK(size_t n) {
}

#include "base/third_party/dmg_fp/dtoa.cc"

#undef Long // To avoid breaking jni code in jumbo builds

0 comments on commit efa1e60

Please sign in to comment.