Move IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to components_st…

…rings. Move the strings IDS_FLAGS_ENHANCED_BOOKMARKS_{NAME,DESCRIPTION} to //components/strings so that they can be shared with iOS. BUG=551954 Review URL: https://codereview.chromium.org/1475293003 Cr-Commit-Position: refs/heads/master@{#361908}
qweri0p · Nov 26, 2015 · ed25e27 · ed25e27
1 parent 7dc5488
commit ed25e27
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt
@@ -342,8 +342,6 @@ IDS_FLAGS_ENABLE_DEVTOOLS_EXPERIMENTS_DESCRIPTION
 IDS_FLAGS_ENABLE_DEVTOOLS_EXPERIMENTS_NAME
 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_DESCRIPTION
 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_NAME
-IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_DESCRIPTION
-IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_NAME
 IDS_FLAGS_ENABLE_EXPERIMENTAL_CANVAS_FEATURES_DESCRIPTION
 IDS_FLAGS_ENABLE_EXPERIMENTAL_CANVAS_FEATURES_NAME
 IDS_FLAGS_ENABLE_GESTURE_TAP_HIGHLIGHTING_DESCRIPTION

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
@@ -6411,12 +6411,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
       <message name="IDS_FLAGS_APPS_SHOW_ON_FIRST_PAINT_DESCRIPTION" desc="Description of flag to enable show-on-first-paint for apps.">
         Show apps windows after the first paint. Windows will be shown significantly later for heavy apps loading resources synchronously but it will be insignificant for apps that load most of their resources asynchronously.
       </message>
-      <message name="IDS_FLAGS_ENHANCED_BOOKMARKS_NAME" desc="Name of about:flags option to enable Enhanced Bookmarks extension.">
-        Enhanced Bookmarks
-      </message>
-      <message name="IDS_FLAGS_ENHANCED_BOOKMARKS_DESCRIPTION" desc="Description of about:flags option to enable Enhanced Bookmarks extension.">
-        Provides an off switch for enhanced bookmarks experiment
-      </message>
       <message name="IDS_FLAGS_SITE_ENGAGEMENT_SERVICE_NAME" desc="Title for the flag to enable the site engagement service.">
         Site Engagement Service
       </message>

diff --git a/components/components_strings.grd b/components/components_strings.grd
@@ -139,6 +139,7 @@
       <part file="crash_strings.grdp" />
       <part file="data_reduction_proxy_strings.grdp" />
       <part file="dom_distiller_strings.grdp" />
+      <part file="enhanced_bookmarks_strings.grdp" />
       <part file="error_page_strings.grdp" />
       <part file="flags_ui_strings.grdp" />
       <part file="omnibox_strings.grdp" />

diff --git a/components/enhanced_bookmarks_strings.grdp b/components/enhanced_bookmarks_strings.grdp
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<grit-part>
+  <message name="IDS_FLAGS_ENHANCED_BOOKMARKS_NAME" desc="Name of about:flags option to enable Enhanced Bookmarks extension.">
+    Enhanced Bookmarks
+  </message>
+  <message name="IDS_FLAGS_ENHANCED_BOOKMARKS_DESCRIPTION" desc="Description of about:flags option to enable Enhanced Bookmarks extension.">
+    Provides an off switch for enhanced bookmarks experiment
+  </message>
+</grit-part>