Skip to content

Commit

Permalink
[PA] Make base a public_deps of crypto/
Browse files Browse the repository at this point in the history
The public interface of this target do include several headers from
base. It means `base` is a `public_deps`, not an internal `deps`.

See GN doc explaining this:
https://gn.googlesource.com/gn/+/master/docs/reference.md#discussion

Context: If we don't apply this patch, the PartitionAllocator library is
not going to be able to stand alone completely. Its public_config is not
going to be properly propagated toward all of its dependants. It will
fail to compile some dependants who do not depends on base explicitly.

Bug: chromium:1467773
Change-Id: I279087e41e0131546d8bbea55b9089e1429617ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922270
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207522}
  • Loading branch information
ArthurSonzogni authored and Chromium LUCI CQ committed Oct 10, 2023
1 parent fdd9d05 commit e6681dc
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions crypto/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,11 @@ component("crypto") {
"unexportable_key_software_unsecure.cc",
]

deps = [
"//base",
"//base/third_party/dynamic_annotations",
]
deps = [ "//base/third_party/dynamic_annotations" ]

public_deps = [
":buildflags",
"//base",
"//third_party/boringssl",
]

Expand Down

0 comments on commit e6681dc

Please sign in to comment.