Skip to content

Commit

Permalink
Do not create srcjar in androidx vectordrawable.
Browse files Browse the repository at this point in the history
Bug: 938604
Change-Id: I376eeac8d5cf3fd6b8b5965953383ffcafa292a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787705
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#694357}
  • Loading branch information
Ben Joyce authored and Commit Bot committed Sep 6, 2019
1 parent 614248d commit dbf11d0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions third_party/android_deps/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,7 @@ android_aar_prebuilt("androidx_vectordrawable_vectordrawable_java") {
":androidx_annotation_annotation_java",
":androidx_core_core_java",
]
create_srcjar = false
}

# This is generated, do not edit. Update BuildConfigGenerator.groovy instead.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,11 @@ class BuildConfigGenerator extends DefaultTask {
// the library is present: b/70887421
sb.append(' deps += [":androidx_fragment_fragment_java"]\n')
break
case 'androidx_vectordrawable_vectordrawable':
case 'com_android_support_support_vector_drawable':
// Target has AIDL, but we don't support it yet: http://crbug.com/644439
sb.append(' create_srcjar = false\n')
break
case 'android_arch_lifecycle_runtime':
case 'android_arch_lifecycle_viewmodel':
sb.append(' # https://crbug.com/887942#c1\n')
Expand All @@ -271,10 +276,6 @@ class BuildConfigGenerator extends DefaultTask {
sb.append(' # https://crbug.com/989505\n')
sb.append(' jar_excluded_patterns = ["META-INF/proguard/*"]\n')
break
case 'com_android_support_support_vector_drawable':
// Target has AIDL, but we don't support it yet: http://crbug.com/644439
sb.append(' create_srcjar = false\n')
break
case 'com_android_support_transition':
// Not specified in the POM, compileOnly dependency not supposed to be used unless
// the library is present: b/70887421
Expand Down

0 comments on commit dbf11d0

Please sign in to comment.