Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WebUI: Add ESLint plugin for checking JSDoc
Specifically, this adds eslint-plugin-jsdoc as dependency. eslint-plugin-jsdoc enables more fine grained control for JSDoc linting in ESLint. This enables ESLint to check that JSDoc are valid in TypeScript files, since the style guide for TypeScript states that types should not be repeated in JSDoc for TypeScript files, but the builtin valid-jsdoc rule requires type to be present. Also the builtin JSDoc related rules (require-jsdoc, valid-jsdoc) are deprecated (https://eslint.org/blog/2018/11/jsdoc-end-of-life) and ESLint officially recommends to use eslint-plugin-jsdoc. This increases the uncompressed node_modules size by about 1.06MB, but all those are only for developments and shouldn't affect Chrome build size. Bug: b:211723843 Test: Check that the plugin works with ESLint in CCA with CL:3372522. Change-Id: I4fdcab145d03d82170f1815e354499f00bb32537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3371546 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Auto-Submit: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#956990}
- Loading branch information