Skip to content

Commit

Permalink
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /native_client_sdk.
Browse files Browse the repository at this point in the history
Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=binji@chromium.org

Bug: 925652
Change-Id: Idecce16799fd41fc5aae7e02f8df655550ce3d86
Reviewed-on: https://chromium-review.googlesource.com/c/1438256
Commit-Queue: Sam Clegg <sbc@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626746}
  • Loading branch information
pwnall authored and Commit Bot committed Jan 28, 2019
1 parent 41d634c commit d89b790
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ TEST_P(HttpFsTest, FTruncate) {
}

// Instantiate the above tests for all caching types.
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
Default,
HttpFsTest,
::testing::Values((uint32_t)kStringMapParamCacheNone,
Expand Down Expand Up @@ -255,10 +255,10 @@ TEST_P(HttpFsLargeFileTest, GetStat) {
// Instantiate the large file tests, only when cache content is off.
// TODO(binji): make cache content smarter, so it doesn't try to cache enormous
// files. See http://crbug.com/369279.
INSTANTIATE_TEST_CASE_P(Default,
HttpFsLargeFileTest,
::testing::Values((uint32_t)kStringMapParamCacheNone,
(uint32_t)kStringMapParamCacheStat));
INSTANTIATE_TEST_SUITE_P(Default,
HttpFsLargeFileTest,
::testing::Values((uint32_t)kStringMapParamCacheNone,
(uint32_t)kStringMapParamCacheStat));

TEST(HttpFsDirTest, Root) {
StringMap_t args;
Expand Down

0 comments on commit d89b790

Please sign in to comment.