[gin] Remove array change-by-copy flag

The feature has shipped since M110 Bug: v8:12764 Change-Id: I759456825e61c4cf6630cad264e5f3fc2ac171d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5035293 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225364}
qweri0p · Nov 16, 2023 · d39be82 · d39be82
1 parent 9b877f8
commit d39be82
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/gin/gin_features.cc b/gin/gin_features.cc
@@ -197,11 +197,6 @@ BASE_FEATURE(kJavaScriptSymbolAsWeakMapKey,
              "JavaScriptSymbolAsWeakMapKey",
              base::FEATURE_ENABLED_BY_DEFAULT);
 
-// Enables the change-Array-by-copy proposal.
-BASE_FEATURE(kJavaScriptChangeArrayByCopy,
-             "JavaScriptChangeArrayByCopy",
-             base::FEATURE_ENABLED_BY_DEFAULT);
-
 // Enables the Resizable ArrayBuffer proposal.
 BASE_FEATURE(kJavaScriptRabGsab,
              "JavaScriptRabGsab",

diff --git a/gin/gin_features.h b/gin/gin_features.h
@@ -57,7 +57,6 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kV8TurboFastApiCalls);
 GIN_EXPORT BASE_DECLARE_FEATURE(kV8UseLibmTrigFunctions);
 GIN_EXPORT extern const base::FeatureParam<base::TimeDelta>
     kV8MemoryReducerStartDelay;
-GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptChangeArrayByCopy);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRabGsab);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptRegExpUnicodeSets);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptSymbolAsWeakMapKey);

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
@@ -365,9 +365,6 @@ void SetFlags(IsolateHolder::ScriptMode mode,
   SetV8FlagsIfOverridden(features::kJavaScriptSymbolAsWeakMapKey,
                          "--harmony-symbol-as-weakmap-key",
                          "--no-harmony-symbol-as-weakmap-key");
-  SetV8FlagsIfOverridden(features::kJavaScriptChangeArrayByCopy,
-                         "--harmony-change-array-by-copy",
-                         "--no-harmony-change-array-by-copy");
   if (base::FeatureList::IsEnabled(features::kJavaScriptRabGsab)) {
     SetV8Flags("--harmony-rab-gsab");
   } else {