Skip to content

Commit

Permalink
Resume and terminate JS execution upon Page.reload
Browse files Browse the repository at this point in the history
This takes care of inspector-protocol/page/reload-on-breakpoint.js
with --enable-features=RenderDocument:level/all-frames. See https://crrev.com/c/3574665 for additional context.

Bug: 1489393
Change-Id: Ie050c32ec693e5f68347d4ae145393fc149b0901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4914433
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1205889}
  • Loading branch information
caseq authored and Chromium LUCI CQ committed Oct 5, 2023
1 parent 1a94269 commit d013d12
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,7 @@ protocol::Response InspectorPageAgent::reload(
pending_script_to_evaluate_on_load_once_ =
optional_script_to_evaluate_on_load.value_or("");
v8_session_->setSkipAllPauses(true);
v8_session_->resume(true /* terminate on resume */);
return protocol::Response::Success();
}

Expand Down

0 comments on commit d013d12

Please sign in to comment.