Skip to content

Commit

Permalink
Reland "components: Fix 'gn check' errors for omnibox."
Browse files Browse the repository at this point in the history
This reverts commit cc83d2d.

Tested on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check out-gn/Release //components/omnibox/*

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1242973003

Cr-Commit-Position: refs/heads/master@{#339700}
  • Loading branch information
tfarina authored and Commit bot committed Jul 21, 2015
1 parent a250ccf commit c312b42
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ check_targets = [
"//components/app_modal/*",
"//components/autofill/*",
"//components/bookmarks/*",
"//components/google/*",
"//components/omnibox/*",
"//components/os_crypt/*",
"//components/pref_registry/*",
"//components/undo/*",
Expand Down
2 changes: 1 addition & 1 deletion components/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,8 @@ test("components_unittests") {
"//components/undo:unit_tests",
"//components/update_client:unit_tests",
"//components/variations:unit_tests",
"//components/web_resource:unit_tests",
"//components/webcrypto:unit_tests",
"//components/web_resource:unit_tests",
"//components/webdata/common:unit_tests",

# These are the deps required by the code in this target.
Expand Down
9 changes: 9 additions & 0 deletions components/omnibox/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,15 @@ source_set("browser") {
":in_memory_url_index_cache_proto",
"//base",
"//base:i18n",
"//base:prefs",
"//components/bookmarks/browser",
"//components/keyed_service/core",
"//components/pref_registry",
"//components/query_parser",
"//components/resources",
"//components/search",
"//components/search_engines",
"//components/sessions",
"//components/strings",
"//components/url_fixer",
"//components/variations",
Expand Down Expand Up @@ -122,6 +124,8 @@ static_library("test_support") {
":browser",
"//base",
"//components/metrics/proto",
"//components/search_engines",
"//net",
"//testing/gmock",
]
}
Expand All @@ -144,7 +148,12 @@ source_set("unit_tests") {
deps = [
":browser",
":test_support",
"//base",
"//components/search",
"//components/search_engines",
"//components/variations",
"//testing/gmock",
"//testing/gtest",
"//url",
]
}
8 changes: 8 additions & 0 deletions components/sessions/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ if (!is_ios) {

configs += [ ":implementation" ]

public_deps = [
":shared",
]

deps = [
":shared",
"//base",
Expand All @@ -40,6 +44,10 @@ if (!is_ios) {
"ios/ios_serialized_navigation_driver.h",
]

public_deps = [
":shared",
]

deps = [
":shared",
"//base",
Expand Down

0 comments on commit c312b42

Please sign in to comment.