Skip to content

Commit

Permalink
Fix operator== use in site_per_process_hit_test_browsertest.cc
Browse files Browse the repository at this point in the history
Clang recently received a bug fix for how it finds operator==, causing
it to error on this code.

It seems like there was a mistake in this code, which is supposed to
compare the cursor's *type*, and the Clang bug made the compiler
silently accept it before.

Bug: 1495664
Change-Id: I5bd54ac2c7d5023af31d380a3b8403011ae6f14c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4974103
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214798}
  • Loading branch information
zmodem authored and Chromium LUCI CQ committed Oct 25, 2023
1 parent 9a51e39 commit b84b6ad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions content/browser/site_per_process_hit_test_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4460,7 +4460,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessHitTestBrowserTest,
set_cursor_interceptor->Wait();
EXPECT_TRUE(set_cursor_interceptor->cursor().has_value());
EXPECT_EQ(ui::mojom::CursorType::kPointer,
set_cursor_interceptor->cursor());
set_cursor_interceptor->cursor()->type());
}
}

Expand Down Expand Up @@ -4528,7 +4528,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessHitTestBrowserTest,
set_cursor_interceptor->Wait();
EXPECT_TRUE(set_cursor_interceptor->cursor().has_value());
EXPECT_EQ(ui::mojom::CursorType::kPointer,
set_cursor_interceptor->cursor());
set_cursor_interceptor->cursor()->type());
}
#endif // !BUILDFLAG(IS_ANDROID)

Expand Down

0 comments on commit b84b6ad

Please sign in to comment.