[Code Health] Remove expired histograms Mojo.Channel.Linux.SharedMemW…

…riteBytes* OBSOLETE_HISTOGRAM[Mojo.Channel.Linux.SharedMemWriteBytes]=Expired in 2021 OBSOLETE_HISTOGRAM[Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoLock]=Expired in 2021 OBSOLETE_HISTOGRAM[Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoSpace]=Expired in 2022 OBSOLETE_HISTOGRAM[Mojo.Channel.Linux.SharedMemWriteBytes_Fail_TooLarge]=Expired in 2022 Bug: 1447227 Change-Id: I687e27cb5cbe164e07984f8316166680006831f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582622 Reviewed-by: Luc Nguyen <lucnguyen@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/main@{#1153846}
qweri0p · Jun 6, 2023 · b471727 · b471727
1 parent 9c146d3
commit b471727
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 45 deletions.
diff --git a/mojo/core/channel_linux.cc b/mojo/core/channel_linux.cc
@@ -399,14 +399,10 @@ class ChannelLinux::SharedBuffer {
     DCHECK(len);
 
     if (len > usable_len()) {
-      UMA_HISTOGRAM_COUNTS_100000(
-          "Mojo.Channel.Linux.SharedMemWriteBytes_Fail_TooLarge", len);
       return Error::kGeneralError;
     }
 
     if (!TryLockForWriting()) {
-      UMA_HISTOGRAM_COUNTS_100000(
-          "Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoLock", len);
       return Error::kGeneralError;
     }
 
@@ -426,8 +422,6 @@ class ChannelLinux::SharedBuffer {
 
     if (space_available <= len) {
       UnlockForWriting();
-      UMA_HISTOGRAM_COUNTS_100000(
-          "Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoSpace", len);
 
       return Error::kGeneralError;
     }

diff --git a/tools/metrics/histograms/metadata/others/histograms.xml b/tools/metrics/histograms/metadata/others/histograms.xml
@@ -7982,45 +7982,6 @@ chromium-metrics-reviews@google.com.
   </summary>
 </histogram>
 
-<histogram name="Mojo.Channel.Linux.SharedMemWriteBytes" units="bytes"
-    expires_after="2021-11-01">
-  <owner>bgeffon@chromium.org</owner>
-  <owner>rockot@google.com</owner>
-  <summary>
-    The size in bytes of individual messages written into shared memory.
-  </summary>
-</histogram>
-
-<histogram name="Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoLock"
-    units="bytes" expires_after="2021-11-01">
-  <owner>bgeffon@chromium.org</owner>
-  <owner>rockot@google.com</owner>
-  <summary>
-    The size in bytes of individual messages that could not be written due to
-    lock contention.
-  </summary>
-</histogram>
-
-<histogram name="Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoSpace"
-    units="bytes" expires_after="2022-05-08">
-  <owner>bgeffon@chromium.org</owner>
-  <owner>rockot@google.com</owner>
-  <summary>
-    The size in bytes of individual messages that could not be written due to
-    shared memory buffer exhaustion.
-  </summary>
-</histogram>
-
-<histogram name="Mojo.Channel.Linux.SharedMemWriteBytes_Fail_TooLarge"
-    units="bytes" expires_after="2022-05-08">
-  <owner>bgeffon@chromium.org</owner>
-  <owner>rockot@google.com</owner>
-  <summary>
-    The size in bytes of individual messages that could not be written due to
-    message being larger than the shared buffer size.
-  </summary>
-</histogram>
-
 <histogram name="Mojo.Channel.WriteMessageHandles" units="count"
     expires_after="2021-11-07">
   <owner>amistry@chromium.org</owner>