Cleanup: Pass std::string as const reference from chrome_elf/

Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=caitkp@chromium.org,robertshield@chromium.org Review URL: https://codereview.chromium.org/1352793003 Cr-Commit-Position: refs/heads/master@{#349887}
qweri0p · Sep 20, 2015 · b3289e3 · b3289e3
1 parent 9124692
commit b3289e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/chrome_elf/dll_hash/dll_hash.cc b/chrome_elf/dll_hash/dll_hash.cc
@@ -5,7 +5,7 @@
 #include "base/hash.h"
 #include "chrome_elf/dll_hash/dll_hash.h"
 
-int DllNameToHash(std::string dll_name) {
+int DllNameToHash(const std::string& dll_name) {
   uint32 data = base::Hash(dll_name);
 
   // Strip off the signed bit because UMA doesn't support negative values,

diff --git a/chrome_elf/dll_hash/dll_hash.h b/chrome_elf/dll_hash/dll_hash.h
@@ -8,6 +8,6 @@
 #include <string>
 
 // Convert a dll name to a hash that can be sent via UMA.
-int DllNameToHash(std::string dll_name);
+int DllNameToHash(const std::string& dll_name);
 
 #endif  // CHROME_ELF_DLL_HASH_DLL_HASH_H_